New changes / features for composefs-backend #1644
Conversation
Johan-Liebert1
force-pushed
the
composefs-to-filesystem
branch
from
3e03d56 to
b4cd3c2
Compare
Johan-Liebert1
force-pushed
the
composefs-to-filesystem
branch
from
b4cd3c2 to
6134880
Compare
Johan-Liebert1
force-pushed
the
composefs-to-filesystem
branch
3 times, most recently
from
82ee61e to
ebe252c
Compare
Johan-Liebert1
changed the title
|
Currently with the option Does it make sense to do the above until we have systemd-boot support in bootupd? |
|
Yes I'll try to take a look at coreos/bootupd#978 soon. Otherwise see #806 (comment) - I think the "no bootupd = systemd-boot" path also makes sense and should be relatively straightforward to implement here. |
|
Ah my bad, I think we have some textual (partial semantic) conflicts in #1662 |
|
That's okay. I can rebase on main afterwards |
crates/lib/src/install.rs
Outdated
|
|
||
| #[cfg(feature = "composefs-backend")] | ||
| #[clap(flatten)] | ||
| pub(crate) compoesfs_opts: InstallComposefsOpts, |
There was a problem hiding this comment.
What's your opinion on adding something like typos to the CI? There are quite a few typos across the repo
Johan-Liebert1
force-pushed
the
composefs-to-filesystem
branch
from
b0b66d3 to
791fc9a
Compare
Signed-off-by: Pragyan Poudyal <[email protected]> Signed-off-by: Colin Walters <[email protected]>
We were using composefs-native and composefs-backend interchangeably. Replace all instances of `composefs-native` with `composefs-backend` Move all composefs-backend options to a single struct so that we can test for boolean instead of testing for Some/None for composefs-backend options Signed-off-by: Pragyan Poudyal <[email protected]> Signed-off-by: Colin Walters <[email protected]>
Instead of storing the source imgref in the .origin file, we store the target imgref Signed-off-by: Pragyan Poudyal <[email protected]> Signed-off-by: Colin Walters <[email protected]>
Rename service to bootc-finalize-staged Signed-off-by: Pragyan Poudyal <[email protected]> Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
composefs-to-filesystem
branch
from
791fc9a to
c268ac2
Compare
|
I rebased this one |
|
OK, the new composefs test fails on this one; it's possible I broke something when rebasing, or it's a legit regression. |
Signed-off-by: Pragyan Poudyal <[email protected]> Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
composefs-to-filesystem
branch
from
c268ac2 to
1d384c4
Compare
|
So, |
Gate some lines behind composefs-backend feature Signed-off-by: Pragyan Poudyal <[email protected]>
Johan-Liebert1
force-pushed
the
composefs-to-filesystem
branch
from
a5b8afa to
9243712
Compare
2 participants
Finish up implementation for
install-to-filesystemforcomposefs-backendWe were using composefs-native and composefs-backend interchangeably.
Replace all instances of
composefs-nativewithcomposefs-backendMove all composefs-backend options to a single struct so that we can
test for boolean instead of testing for Some/None for composefs-backend
options
The source imgref was being stored in the .origin file, even if target imgref was
provided. Now we store the target imgref
Start finalize-staged service on update/switch
Add composefs opts to install-to-existing-root